Skip to content

Dockerfile missing runtime deps for newly-merged modules (astroquery, numba, fitsio) #712

@cailmdaley

Description

@cailmdaley

Symptom

Several modules on develop import packages that aren't installed in the ghcr.io/cosmostat/shapepipe:develop image:

Module Missing package
shapepipe.modules.mask_package.mask + mask_runner astroquery
shapepipe.modules.ngmix_package.ngmix + ngmix_runner numba
shapepipe.modules.uncompress_fits_package.uncompress_fits + uncompress_fits_runner fitsio

Each raises ModuleNotFoundError at import time.

Root cause

Likely from a recent merge (PR #702?) that landed module changes requiring new deps without updating the Dockerfile's pip install list. The v2.0 PR (#706) does include these in its Dockerfile rewrite, but develop's Dockerfile lags.

Fix

Add the missing deps to the pip install block in Dockerfile on develop. Quick patch; doesn't need to wait for the v2.0 Dockerfile overhaul in #706.

Caught by

tests/unit/test_imports.py::test_module_imports[...] for the 6 affected modules (xfailed in #708).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions