DATAC1 might be mis documented in README_data.md as having 56 usable bytes when it should be 54?

[xssfox]

When calling freedv_get_bits_per_modem_frame//8 for all the data modes I get the raw byte count for the modem (including the crc length). Eg for DATAC3 I get 128 while in the documentation says 126 - which is what I expect.

For DATAC1 however the documentation says 56 bytes and the call returns back 56, suggesting that the documentation should probably have 54 in it rather than 56 ?

[drowe67]

For DATAC1 however the documentation says 56 bytes and the call returns back 56, suggesting that the documentation should probably have 54 in it rather than 56 ?

DATAC1 looks correct to me, 4096 data bits, 4096/8 - 2 = 510 payload data bytes.

Are you referring to DATC4? That should have 448/8 - 2 payload data bytes, but has 56 in the table in README_data.md

[TheSkorm]

ah sorry, DATAC4

[rafael2k]

I opened a PR which covers this issue:
#73

[rafael2k]

I opened another PR just with the correction to the README

[rafael2k]

#74

[rafael2k]

Thanks @drowe67 ! @xssfox the MR was merged with DATAC4 useful payload fixed.