Rationalise format bar with global preferences and editor-config plugin

[cassidyjames]

Since we have it in the format bar in the header bar, I think we can drop it in the global preferences.

[danirabbit]

I think there was supposed to be a difference like the header one is for the current document and the one in prefs is the global default

[cassidyjames]

Ah. Right now they are bound together so there's not a difference. So I'm 🤷‍♂️. We could drop the global one (then bring it back if we ever differentiate the two), or we could leave it as-is. It's just a little confusing with the same setting in two places right now.

[jeremypw]

The behaviour at the moment is confusing as it depends on whether the editor-config plugin is on or off. The tabs popover for the format bar may or may not have an effect and may or may not be the same as the global preferences.

Maybe the editor-config plugin should be brought into main code and always on? The format bar tab popover would then only appear if the setting is not forced by editor-config (or aternatively would override editor-config for that file).

It should be made clear the global settings are fallback settings if not set by editor-config.

[danirabbit]

Yeah personally I think we should have no plugins and just have features or not have them. The plugin set up makes really confusing cases like this where it's hard to know if a preference is going to have an effect or not

[jeremypw]

My inclination would be to manage tabs entirely from the format bar, incorporating editor-config management and preferences there.