Hook secret name mismatch + Helm dependencies issue

[pierluigilenoci]

I found two issues related to the hook secret.

1. In the litmus-agent chart, a secret is created with {{ include "subscriber.fullname" . }}-hook but it is referred to using {{ include "litmus-agent.fullname" . }}-hook.

2. If we set the values subscriber.enabled: false the litmus-agent chart fails to generate the manifest because the string subscriber.fullname is used in the main chart but is generated in the subchart.

Ref:

litmus-helm/charts/litmus-agent/templates/secret.yaml

Line 5 in 2e2d416

name: {{ include "subscriber.fullname" . }}-hook

[pierluigilenoci]

I presume this is also related to another issue

• [HELM UPDATE CONFIG]: Litmus-Agent Hooks break Subscriber-Secret and Subscriber Config Updates litmus#4967
• Cannot re-install litmus-agent after uninstalling it #334

[pierluigilenoci]

@Jonsy13 @ispeakc0de @jongwooo, could you please take a look?

[pierluigilenoci]

[pierluigilenoci]

@Jonsy13 @ispeakc0de I've submitted PR #480 to fix both issues reported here.

The root cause was that 4 parent chart templates were using subscriber.* helpers (defined in the subscriber subchart) instead of litmus-agent.* helpers. This caused:

1. Hook secret name mismatch between creation and reference
2. Chart render failure when subscriber.enabled: false

The fix replaces all subscriber.* references with litmus-agent.* in the parent chart templates. Verified with helm template in both configurations.