Skip to content

pkgdev tatt: "no src_test" check is bogus #224

@thesamesam

Description

@thesamesam

611a1c7 introduced a check for whether, with --test, the relevant package has a test phase defined. This test isn't correct to do: the default src_test may work just fine for a package and therefore won't appear as a defined phase.

An example of this is app-misc/hello where processing bug 970125 fails at least when run manually with:

# pkgdev tatt --test --api-key $(</srv/tattoo/bugs.key) --bug 970125
!!! no packages define a src_test, and --use-combos is not a positive integer. Cannot create any jobs, exiting...
created config /etc/portage/package.accept_keywords/pkgdev_tatt_hello-970125.keywords
created config /etc/portage/env/pkgdev_tatt_hello-970125_no_test
created config /etc/portage/env/pkgdev_tatt_hello-970125_test
created config /etc/portage/package.use/pkgdev_tatt_hello-970125
created config /etc/portage/package.env/pkgdev_tatt_hello-970125

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions