fix(DecodeExecdata): skip recursive bundle decode when result would violate IsValid()#357
Open
ScreamingHawk wants to merge 1 commit intomasterfrom
Open
fix(DecodeExecdata): skip recursive bundle decode when result would violate IsValid()#357ScreamingHawk wants to merge 1 commit intomasterfrom
ScreamingHawk wants to merge 1 commit intomasterfrom
Conversation
…iolate IsValid() When a V1 execute call contains a nested transaction targeting the V3 guest module, DecodeExecdata's recursive loop successfully decoded the packed V3 payload and set Nonce (non-nil) while leaving Signature nil. This violates the invariant in IsValid() — nonce and signature must both be set or both nil — which caused ComputeMetaTxnID to fail with: "transactions must have both nonce and signature or neither" Fix: validate the decoded bundle via IsValid() before applying it. If the result is inconsistent (e.g. nonce-without-signature for guest module calls), the transaction is left as calldata rather than promoted to a bundle. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered this bug when trying to recover a failed Trails interaction with my V2 Sequence wallet.
Steps to reproduce:
When a V1/V2 execute call contains a nested transaction targeting the V3 guest module, DecodeExecdata's recursive loop successfully decoded the packed V3 payload and set Nonce (non-nil) while leaving Signature nil. This violates the invariant in IsValid() — nonce and signature must both be set or both nil — which caused ComputeMetaTxnID to fail with:
"transactions must have both nonce and signature or neither"
Fix: validate the decoded bundle via IsValid() before applying it. If the result is inconsistent (e.g. nonce-without-signature for guest module calls), the transaction is left as calldata rather than promoted to a bundle.