fix: add lobby verification lock and gateway disconnect handler#140
Open
fix: add lobby verification lock and gateway disconnect handler#140
Conversation
Wrap matchmaking verify+setLobbyDetails+addLobbyToQueue in a Redis lock to prevent a banned player from bypassing verification between the check and queue addition. Add handleDisconnect lifecycle hook to SocketsGateway and make handleConnection public for proper NestJS gateway lifecycle support.
Adds compile-time type safety for NestJS WebSocket lifecycle hooks.
lukepolo
reviewed
Apr 9, 2026
src/sockets/sockets.gateway.ts
Outdated
| await this.sockets.setupSocket(client, request); | ||
| } | ||
|
|
||
| public handleDisconnect(client: FiveStackWebSocketClient) { |
Contributor
Author
There was a problem hiding this comment.
Removed. The handleDisconnect was a no-op — all cleanup (removing from clients map, deleting Redis keys, marking offline) is already handled by the client.on("close") callback in SocketsService.setupSocket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verifyLobby+setLobbyDetails+addLobbyToQueuesequence in a Redis distributed lock (matchmaking:verify:{lobbyId}) to close the race window where a banned player could bypass verification between the check and queue addition (RACE-API-02)handleDisconnectlifecycle hook toSocketsGatewayand makeshandleConnectionpublic, since NestJS WebSocket gateway lifecycle methods must be public to be recognized (LEAK-API-03)CacheModuleinto the matchmaking module and injectsCacheServiceintoMatchmakingGatewayCloses 5stackgg/5stack-panel#374
Test plan
JoinQueueErrorexceptions fromverifyLobbyare still propagated correctly to the client