fix: specify UTF-8 encoding for subprocess in init_database#606
Open
JasonOA888 wants to merge 1 commit into666ghj:mainfrom
Open
fix: specify UTF-8 encoding for subprocess in init_database#606JasonOA888 wants to merge 1 commit into666ghj:mainfrom
JasonOA888 wants to merge 1 commit into666ghj:mainfrom
Conversation
- subprocess.run with text=True uses system encoding (GBK on Windows) - Causes UnicodeDecodeError when reading SQL files with UTF-8 content - Explicitly set encoding='utf-8' to fix the issue Fixes 666ghj#605
dosubot
bot
added
the
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #605 - 修复 Windows 上数据库初始化的 GBK 编码错误。
Problem
用户在 Windows 上运行
python main.py --init-db时遇到：Root Cause
subprocess.run的text=True参数在 Windows 上默认使用系统编码 (GBK)，而不是 UTF-8。当 SQL 文件包含 UTF-8 字符时，会导致解码失败。Solution
显式指定
encoding='utf-8'参数。Changes
MindSpider/main.py: 在initialize_database()的 subprocess.run 中添加encoding='utf-8'Fixes #605