Suppress mypy errors due to untyped libraries#62
Open
hettlage wants to merge 1 commit intoAEONplus:mainfrom
Open
Suppress mypy errors due to untyped libraries#62hettlage wants to merge 1 commit intoAEONplus:mainfrom
hettlage wants to merge 1 commit intoAEONplus:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several libraries used by AEONlib don't have type hints and therefore give errors when you type-check with mypy. The pyproject.toml file has been updated to tell mypy to ignore these libraries.
The only error remaining is for the lxml library. There exists a typing package for this library. I would suggest to add this as a dev dependency and remove it from the optional dependency group "lt".