feat: added public directory + merge /home + /public

[RohitKushvaha01]

No description provided.

[greptile-apps]

Greptile Summary

This PR consolidates the terminal's home directory storage by replacing the gated "Terminal Home" file-browser entry (which required the Terminal plugin to be installed) with an unconditional "Terminal Public" entry, and migrates existing alpine/home/alpine/root contents into a unified public/ directory that is then bound to /public, /home, and /root inside the proot environment.

Confidence Score: 5/5

Safe to merge; all prior P1 concerns have been addressed by the developer and only a P2 improvement suggestion remains.

All meaningful prior review concerns (Terminal guard, collision during migration, shared /home+/root path) have been acknowledged and explicitly accepted by the developer as intentional trade-offs. The only new finding is a P2 suggestion to add a sentinel file so the migration logic is skipped on subsequent terminal launches, which is a quality improvement rather than a correctness issue.

init-sandbox.sh — migration runs on every launch without a completion marker.

Important Files Changed

Filename	Overview
src/pages/fileBrowser/fileBrowser.js	Replaced the gated "Terminal Home" entry (behind Terminal.isInstalled/isSupported) with an unconditional "Terminal Public" entry pointing to cordova.file.dataDirectory + "public". Logic is straightforward and correct; the try/catch handles edge cases gracefully.
src/plugins/terminal/scripts/init-sandbox.sh	Adds a one-time migration (move_all) that runs on every terminal launch to move contents of alpine/home and alpine/root into the new public/ directory; also binds public/ to both /home and /root inside proot. Migration logic is correct but runs unconditionally on every launch without a completion marker.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[init-sandbox.sh runs on every terminal launch] --> B[mkdir -p PREFIX/public]
    B --> C[move_all: alpine/home to public/]
    C --> D{alpine/home non-empty?}
    D -- No --> E[skip]
    D -- Yes --> F[mv -f files to public/]
    F --> G[move_all: alpine/root to public/]
    E --> G
    G --> H{alpine/root non-empty?}
    H -- No --> I[skip]
    H -- Yes --> J[mv -f files to public/ - silent overwrite on name collision]
    I --> K[proot launch]
    J --> K
    K --> L[bind PREFIX/public to /public]
    K --> M[bind PREFIX/public to /home]
    K --> N[bind PREFIX/public to /root]
    L & M & N --> O[All three paths share the same host directory]

    P[fileBrowser.js getAllStorages] --> Q{terminal-public already listed?}
    Q -- No --> R[pushFolder Terminal Public]
    Q -- Yes --> S[skip]

Loading

_{Reviews (4): Last reviewed commit: "feat: merged /root /home and /public" | Re-trigger Greptile}

[RohitKushvaha01]

@bajrangCoder, I think the public and home directories should be merged. They just cause more confusion and don’t benefit security much either.

[bajrangCoder]

@bajrangCoder, I think the public and home directories should be merged. They just cause more confusion and don’t benefit security much either.

Hm, Merge it but keep the public(for users , APIs built around it)

[RohitKushvaha01]

@greptileai

[RohitKushvaha01]

@greptileai