FT0: fix return type mismatch in ChannelData getters (int16_t)#15303
Open
spulawsk wants to merge 2 commits intoAliceO2Group:devfrom
Open
FT0: fix return type mismatch in ChannelData getters (int16_t)#15303spulawsk wants to merge 2 commits intoAliceO2Group:devfrom
spulawsk wants to merge 2 commits intoAliceO2Group:devfrom
Conversation
spulawsk
requested review from
afurs,
andreasmolander,
jotwinow and
sahilupadhyaya92
as code owners
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a type inconsistency in
ChannelDatagetters.The internal data members:
CFDTime(int16_t)QTCAmpl(int16_t)were already stored as
int16_t, but the getters returned a different type.This change updates:
getTime()getAmp()to return
int16_t, ensuring consistency with the underlying data.