Skip to content

[O2B-1557] Force all filters managed by FilteringModel to extend FilterModel or SelectionModel#2141

Open
NarrowsProjects wants to merge 1 commit intoimprov/O2B-1552/Move-ad-hoc-filters-inside-runsOverviewModel-to-filteringModelfrom
improv/O2B-1557/Force-all-filters-managed-by-FilteringModel-to-extend-FilterModel-or-SelectionModel
Open

[O2B-1557] Force all filters managed by FilteringModel to extend FilterModel or SelectionModel#2141
NarrowsProjects wants to merge 1 commit intoimprov/O2B-1552/Move-ad-hoc-filters-inside-runsOverviewModel-to-filteringModelfrom
improv/O2B-1557/Force-all-filters-managed-by-FilteringModel-to-extend-FilterModel-or-SelectionModel

Conversation

@NarrowsProjects
Copy link
Copy Markdown
Collaborator

@NarrowsProjects NarrowsProjects commented Apr 21, 2026

…del or SelectionModel

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • N/A

Notable changes for developers:

  • Now all put into the filtering model must extend SelectionModel or FilterModel

Changes made to the database:

  • N/A

@NarrowsProjects NarrowsProjects self-assigned this Apr 21, 2026
@NarrowsProjects NarrowsProjects added frontend javascript Pull requests that update Javascript code labels Apr 21, 2026
@NarrowsProjects NarrowsProjects changed the title chore: force all filters managed by FilteringModel to extend FilterMo… [O2B-1557] Force all filters managed by FilteringModel to extend FilterModel or SelectionModel Apr 21, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.83%. Comparing base (4e9559b) to head (ee70acf).
⚠️ Report is 4 commits behind head on improv/O2B-1552/Move-ad-hoc-filters-inside-runsOverviewModel-to-filteringModel.

Files with missing lines Patch % Lines
...public/components/Filters/common/FilteringModel.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                                                Coverage Diff                                                 @@
##           improv/O2B-1552/Move-ad-hoc-filters-inside-runsOverviewModel-to-filteringModel    #2141      +/-   ##
==================================================================================================================
- Coverage                                                                           45.99%   45.83%   -0.16%     
==================================================================================================================
  Files                                                                                1037     1036       -1     
  Lines                                                                               17129    17123       -6     
  Branches                                                                             3108     3109       +1     
==================================================================================================================
- Hits                                                                                 7878     7848      -30     
- Misses                                                                               9251     9275      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

1 participant