Skip to content

[PWGHF] Added safety checks before using ccdb efficiency objects #15653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apalasciano merged 2 commits into from
Apr 5, 2026
Merged

[PWGHF] Added safety checks before using ccdb efficiency objects #15653

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c03ee4
resolving conflict in rebasing
deependra170598 Mar 31, 2026
1173ad3
adding safety checks before fetching ccdb efficiency object
deependra170598 Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 25 additions & 13 deletions PWGHF/HFC/Tasks/taskCorrelationDstarHadrons.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,8 @@ struct HfTaskCorrelationDstarHadrons {
HistogramRegistry registry{"registry", {}, OutputObjHandlingPolicy::AnalysisObject, true, true};

o2::ccdb::CcdbApi ccdbApi;
std::vector<TH1F*> vecHistEfficiencyDstar;
std::vector<TH1D*> vecHistEfficiencyTracks;
std::vector<TH1*> vecHistEfficiencyDstar;
std::vector<TH1*> vecHistEfficiencyTracks;

void init(InitContext&)
{
Expand Down Expand Up @@ -166,12 +166,12 @@ struct HfTaskCorrelationDstarHadrons {
vecHistEfficiencyTracks.resize(nEfficiencyHist);

for (int iHist = 0; iHist < nEfficiencyHist; iHist++) {
vecHistEfficiencyDstar[iHist] = dynamic_cast<TH1F*>(efficiencyDstarRootFile->Get(Form("hEfficiencyDstar_%d", iHist)));
vecHistEfficiencyDstar[iHist] = dynamic_cast<TH1*>(efficiencyDstarRootFile->Get(Form("hEfficiencyDstar_%d", iHist)));
if (!vecHistEfficiencyDstar[iHist]) {
LOGF(fatal, "Failed to retrieve Dstar efficiency histogram hEfficiencyDstar_%d from file", iHist);
}

vecHistEfficiencyTracks[iHist] = dynamic_cast<TH1D*>(efficiencyTracksRootFile->Get(Form("hEfficiencyTracks_%d", iHist)));
vecHistEfficiencyTracks[iHist] = dynamic_cast<TH1*>(efficiencyTracksRootFile->Get(Form("hEfficiencyTracks_%d", iHist)));
if (!vecHistEfficiencyTracks[iHist]) {
LOGF(fatal, "Failed to retrieve track efficiency histogram hEfficiencyTracks_%d from file", iHist);
}
Expand Down Expand Up @@ -212,19 +212,31 @@ struct HfTaskCorrelationDstarHadrons {
// if (ptTrack > 10.0) {
// ptTrack = 10.5;
// }
float netEfficiencyWeight = 1.0;
float netEfficiencyWeight = 1.0, efficiencyWeightDstar = 1.0, efficiencyWeightTracks = 1.0;

if (applyEfficiency && !useCcdbEfficiency) {
float const efficiencyWeightDstar = efficiencyDstar->at(effBinPtDstar);
// LOG(info)<<"efficiencyWeightDstar "<<efficiencyWeightDstar;
float const efficiencyWeightTracks = efficiencyTracks->at(effBinPtTrack);
// LOG(info)<<"efficiencyWeightTracks "<<efficiencyWeightTracks;
efficiencyWeightDstar = efficiencyDstar->at(effBinPtDstar);
efficiencyWeightTracks = efficiencyTracks->at(effBinPtTrack);
netEfficiencyWeight = 1.0 / (efficiencyWeightDstar * efficiencyWeightTracks);
} else if (applyEfficiency && useCcdbEfficiency && nEfficiencyHist == 1) {
float const efficiencyWeightDstar = vecHistEfficiencyDstar[0]->GetBinContent(vecHistEfficiencyDstar[0]->GetXaxis()->FindBin(ptDstar));
// LOG(info)<<"efficiencyWeightDstar "<<efficiencyWeightDstar;
float const efficiencyWeightTracks = vecHistEfficiencyTracks[0]->GetBinContent(vecHistEfficiencyTracks[0]->GetXaxis()->FindBin(ptTrack));
// LOG(info)<<"efficiencyWeightTracks "<<efficiencyWeightTracks;
float const ptEffLowEdgeDstar = vecHistEfficiencyDstar[0]->GetXaxis()->GetBinLowEdge(1);
if (ptDstar <= ptEffLowEdgeDstar) { // pT of current dstar candidate is lower than the lower edge of the pT axis
efficiencyWeightDstar = vecHistEfficiencyDstar[0]->GetBinContent(1);
} else {
efficiencyWeightDstar = vecHistEfficiencyDstar[0]->GetBinContent(vecHistEfficiencyDstar[0]->GetXaxis()->FindBin(ptDstar));
if (!efficiencyWeightDstar) {
LOGF(fatal, "Dstar efficiency weight can't be zero.");
}
}
float const ptEffLowEdgeTrack = vecHistEfficiencyTracks[0]->GetBinLowEdge(1);
if (ptTrack <= ptEffLowEdgeTrack) { // pT of current track is lower than the lower edge of the pT axis
efficiencyWeightTracks = vecHistEfficiencyTracks[0]->GetBinContent(1);
} else {
efficiencyWeightTracks = vecHistEfficiencyTracks[0]->GetBinContent(vecHistEfficiencyTracks[0]->GetXaxis()->FindBin(ptTrack));
if (!efficiencyWeightTracks) {
Copy link
Copy Markdown
Collaborator

@vkucera vkucera Apr 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong. You convert float to bool and compare it to false. For that to happen, the float would have to be exactly 0 which almost never happens if the value is a result of a calculation. Furthermore, the syntax signals the intention of using a bool value which is not the case.

LOGF(fatal, "track efficiency weight can't be zero");
}
}
netEfficiencyWeight = 1.0 / (efficiencyWeightDstar * efficiencyWeightTracks);
} else if (applyEfficiency && useCcdbEfficiency && nEfficiencyHist > 1) {
// to do
Expand Down
Loading