[PWGJE] Updating jetD0AngSubstructure.cxx#15914
Open
pdhankhe wants to merge 17 commits intoAliceO2Group:masterfrom
Open
[PWGJE] Updating jetD0AngSubstructure.cxx#15914pdhankhe wants to merge 17 commits intoAliceO2Group:masterfrom
pdhankhe wants to merge 17 commits intoAliceO2Group:masterfrom
Conversation
Contributor
pdhankhe
commented
Apr 22, 2026
pdhankhe
commented
- Fixed the formatting issues of columns
- Added task to match detector level and particle level Monte Carlo particles.
- Added an additional task to calculate the Monte Carlo efficiency.
- Using templated analyse functions to easily define process functions for other particles than D0 if desired.
Please consider the following formatting changes to AliceO2Group#15311
Please consider the following formatting changes to AliceO2Group#15311
- Added task to analyse D0 candidates from experimental data. Histograms for different observables such as angularity etc. are made for quick checking purposes. - Added task to match detector level and particle level Monte Carlo particles. - Added an additional task to calculate the Monte Carlo efficiency. - Using templated analyse functions to easily define processfunctions for other particles than D0 if desired.
[PWGJE] Updated jetD0AngSubstructure.cxx
Pushing the updates from dev branch to master
Updated code to obey style guidelines.
pdhankhe
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa,
mhemmer-cern,
nzardosh and
raymondEhlers
as code owners
|
O2 linter results: ❌ 0 errors, |
github-actions
Bot
changed the title
nzardosh
reviewed
Apr 22, 2026
|
|
||
| // | ||
| #include <PWGHF/Core/DecayChannels.h> | ||
| // |
Collaborator
There was a problem hiding this comment.
please rebase to the latest master to avoid changing includes if not needed
| /* | ||
| // Experimental Data (analyseDataChargedSubstructure) | ||
| */ | ||
| HNAME(ex_col); // Collision Counter |
Collaborator
There was a problem hiding this comment.
why do you define these here? What is the operational benefit?
| CandidatesMCP const& /*mcpCandidates*/, | ||
| aod::JetTracks const& tracks, | ||
| aod::JetParticles const& particles, | ||
| HistogramRegistry& registry) |
Collaborator
There was a problem hiding this comment.
the registry should be a member of your struct and accesible everywhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.