[PWGDQ] Change some code for the energy correlator study#15937
Merged
mcoquet642 merged 46 commits intoAliceO2Group:masterfrom Apr 23, 2026
Merged
[PWGDQ] Change some code for the energy correlator study#15937mcoquet642 merged 46 commits intoAliceO2Group:masterfrom
mcoquet642 merged 46 commits intoAliceO2Group:masterfrom
Conversation
|
O2 linter results: ❌ 307 errors, |
Collaborator
|
Please add some description to explain what you are changing in your PRs |
Contributor
Author
Hi @mcoquet642, I add some description now. Thank you! |
mcoquet642
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, the TH2::Interpolate(x, y) method uses bilinear interpolation. This algorithm calculates the weighted average based on the four nearest bin centers.
When the input coordinates (x,y) fall outside the range of the first or last bin centers, the function attempts to interpolate between the edge bin and the Underflow/Overflow bins. Since these bins are often empty (value = 0), the resulting weight drops sharply toward zero, which is physically incorrect for efficiency/acceptance corrections.
To prevent these, I keep the input coordinates to the safe range defined by the centers of the first and last bins. It does not alter the interpolated values for points within the internal range, it simply ensures that points beyond the boundary bin centers returns to the edge values.