Draft
Conversation
- Render proxied external documents in tab panes (bs2:TabBody/ldh:CreateTab/ldh:ActivateTab/ldh:RenderTabPane) - Convert breadcrumb-nav from id to CSS class to support per-pane breadcrumbs; populate breadcrumbs in external tab panes; extract ldh:PopulateBreadcrumbNav named template to DRY up local/external breadcrumb logic - Fix CSS block border selectors: #content-body → .content-body, add intermediate container-fluid level - Narrow btn-edit and btn-create-chart match patterns to require .block ancestor, preventing false matches on action-bar - Fix drag handler match patterns: update stale direct-child path to match new two-level content-body/container-fluid/block structure - Fix modal content-body lookup: use ancestor:: for action-bar buttons, active tab-pane for global buttons, so modals append to the visible pane for proxied documents - Remove dead document-mode-tabs template and broken progress bar update targeting hidden #content-body - Remove unused getModes() override from XSLTWriterBase Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ide auth guard - Prevent click handler from firing on disabled edit button by adding [not(contains-token(@Class, 'disabled'))] predicate - Move ACL and Edit buttons inside the xsl:if auth guard so they are not rendered for unauthorized users - Wrap edit button in pull-right div and add ldh:logo icon to match ACL button structure Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add [not(contains-token(@Class, 'disabled'))] predicate to the btn-edit match template so that clicking a disabled edit button does not open the edit modal. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…param - Replace LinkedDataHub.tabs/tab-counter JS registry with data-uri/data-endpoint attributes directly on tab <li> elements; sd:endpoint() now reads from dataset - Give each external document its own tab pane (one per URI) instead of a shared external pane; tab pane visibility toggled via display:none/block - Rename ldh:CreateTab → ldh:AddTabNavBarListItem (no longer handles rendering); ldh:RenderTab now accepts $tab-pane-id (xs:string) instead of $tab-pane element, since the element is detached after ixsl:replace-element - ProxyRequestFilter: inject MediaTypes, throw NotAcceptableException on no variant match instead of silently returning; remove manual HTML Accept-header inspection - Remove $ac:uri XSLT param and related proxy-target plumbing from XSLTWriterBase and layout.xsl; remove LDH.access_to vocabulary property - Switch service document fetches from ac:build-uri() to ldh:href() throughout - Move srx:sparql bs2:ContentBody template from layout.xsl to document.xsl Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
HTTP test and unit test
…n-bar change The action-bar moved from inside .navbar-fixed-top (120px body padding) to sticky positioning (55px body padding), eliminating the 14px gap that existed between the action-bar and content-body. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.