fix: lowercase CLI enum values in HelpText and error messages (Group 3)#3444
Draft
souvikghosh04 wants to merge 1 commit intomainfrom
Draft
fix: lowercase CLI enum values in HelpText and error messages (Group 3)#3444souvikghosh04 wants to merge 1 commit intomainfrom
souvikghosh04 wants to merge 1 commit intomainfrom
Conversation
Fix 4 issues where CLI help text and error messages showed PascalCase or uppercase enum values instead of the lowercase values required by the JSON schema: InitOptions.cs: - host-mode HelpText: 'Development or Production' -> 'development or production' (#3361) EntityOptions.cs: - rest.methods HelpText: '[GET, POST, ...]' -> '[get, post, ...]' (#3362) - graphql.operation HelpText: '[Query, Mutation]' -> '[query, mutation]' (#3363, #3364) Utils.cs: - REST method error message: Enum.GetNames() -> lowercased names - GraphQL operation error message: enum ToString() -> lowercased strings
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 4 issues where CLI
--helptext and error messages showed PascalCase or UPPERCASE enum values instead of the lowercase values required by the JSON schema.The JSON serialization layer already produces lowercase (via
EnumMemberJsonEnumConverterFactory), so these fixes align the CLI display layer to match.Issues Addressed
--host-mode(init)Development or Productiondevelopment or production--rest.methods(add/update)[GET, POST, PUT, PATCH, DELETE][get, post, put, patch, delete]--graphql.operation(add/update)[Query, Mutation][query, mutation]--graphql.operation(add/update)Files Changed
src/Cli/Commands/InitOptions.cshost-modeHelpText: lowercase enum valuessrc/Cli/Commands/EntityOptions.csrest.methodsandgraphql.operationHelpText: lowercase enum valuessrc/Cli/Utils.csTesting