fix(locale): suppress stack trace for malformed locale files, improve error message#2954
Merged
tastybento merged 1 commit intodevelopfrom Apr 24, 2026
Merged
Conversation
… error message YamlConfiguration.loadConfiguration(File) internally catches parse exceptions and logs them at SEVERE with a full stack trace via Bukkit.getLogger(), bypassing BentoBox's own try-catch entirely. Switch to new YamlConfiguration() + load(file) so BentoBox owns the error handling. Split the catch into InvalidConfigurationException (bad YAML syntax — tells the admin to delete/fix the file and notes English fallback) and a generic Exception fallback. Includes the locale folder name in the message so the admin knows which addon's file is at fault. Related: BentoBoxWorld/Chat#58 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
YamlConfiguration.loadConfiguration(File)is Bukkit's static helper — it internally catchesInvalidConfigurationExceptionand logs it atSEVEREwith a full stack trace viaBukkit.getLogger(), completely bypassing BentoBox's own try-catchnew YamlConfiguration(); yaml.load(file)so BentoBox owns the exception and can log a clean, actionable message insteadInvalidConfigurationException(bad YAML) and genericException, both now log two clean lines: what went wrong and a note that English will be used as a fallbackBefore:
After:
Related: BentoBoxWorld/Chat#58 (fixes the specific malformed file that triggered this)
Fixes #2953
Test plan
🤖 Generated with Claude Code