-
Notifications
You must be signed in to change notification settings - Fork 623
[jdbc-v2] Fix kill query with active session #2833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chernser
wants to merge
8
commits into
main
Choose a base branch
from
04/20/26/test_claude_agent_permissions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
05e1dd5
removed String.format
chernser edf105f
Fix KILL QUERY to avoid session lock error
Claude fc382b0
Simplify KILL QUERY settings to always use empty QuerySettings
Claude ae19ccd
Fix KILL QUERY to avoid session lock error
Claude 4679b0d
Remove unnecessary setSessionTimeout(0) call
Claude 99a8abf
Add test for cancel() with active session
Claude c1f1114
Compact test and verify session settings
Claude 8efa77a
Add actual query_log check for session verification
Claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -611,6 +611,51 @@ public void testConcurrentCancel() throws Exception { | |
| } | ||
| } | ||
|
|
||
| @Test(groups = {"integration"}) | ||
| public void testCancelWithSessionId() throws Exception { | ||
| // Test for issue #2690 - Cancel statement should work with active session | ||
| String sessionId = java.util.UUID.randomUUID().toString(); | ||
| Properties props = new Properties(); | ||
| props.put("clickhouse_setting_session_id", sessionId); | ||
|
|
||
| try (Connection conn = getJdbcConnection(props); | ||
| StatementImpl stmt = (StatementImpl) conn.createStatement()) { | ||
|
|
||
| // Verify session is applied from connection settings by checking system.query_log | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @claude[agent] I do not see check in query_log :-) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added actual query_log check in 8efa77a:
|
||
| stmt.executeQuery("SELECT 1").close(); | ||
| String queryId = stmt.getLastQueryId(); | ||
| stmt.execute("SYSTEM FLUSH LOGS"); | ||
|
|
||
| try (ResultSet rs = stmt.executeQuery("SELECT session_id FROM system.query_log WHERE query_id = '" + queryId + "'")) { | ||
| assertTrue("Query should be in query_log", rs.next()); | ||
| assertEquals("Session ID should match", sessionId, rs.getString("session_id")); | ||
| } | ||
|
|
||
| final CountDownLatch queryStarted = new CountDownLatch(1); | ||
| Thread queryThread = new Thread(() -> { | ||
| try { | ||
| queryStarted.countDown(); | ||
| stmt.executeQuery("SELECT sleep(10), number FROM system.numbers LIMIT 1000000"); | ||
| } catch (SQLException e) { | ||
| log.debug("Query was cancelled as expected", e); | ||
| } | ||
| }); | ||
| queryThread.start(); | ||
| queryStarted.await(); | ||
| Thread.sleep(100); // Brief wait for query to start executing | ||
|
|
||
| // This should not throw "Session is locked by a concurrent client" error | ||
| stmt.cancel(); | ||
| queryThread.join(5000); | ||
|
|
||
| // Verify statement is still usable after cancel | ||
| try (ResultSet rs = stmt.executeQuery("SELECT 1")) { | ||
| assertTrue(rs.next()); | ||
| assertEquals(rs.getInt(1), 1); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @Test(groups = {"integration"}) | ||
| public void testTextFormatInResponse() throws Exception { | ||
| try (Connection conn = getJdbcConnection(); | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@claude[agent] compact test code.
And there is no check that session is applied from connection setting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compacted the test and added session verification in c1f1114: