test Popover#3334
Merged
dreamwasp merged 10 commits intocass-gmt-1601-tooltip-bugfrom Apr 28, 2026
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit ba948f9 ☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## cass-gmt-1601-tooltip-bug #3334 +/- ##
============================================================
Coverage ? 89.25%
============================================================
Files ? 251
Lines ? 4719
Branches ? 1598
============================================================
Hits ? 4212
Misses ? 499
Partials ? 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LinKCoding
approved these changes
Apr 28, 2026
Contributor
LinKCoding
left a comment
LinKCoding
left a comment
There was a problem hiding this comment.
checked over popover, tooltip, and infotip -- all looking good!
Collaborator
|
📬 Published Alpha Packages:
|
LinKCoding
reviewed
Apr 28, 2026
| * @param isRtl - Whether the element is in an RTL context. | ||
| * @param useLogicalProperties - Whether logical properties are enabled. | ||
| * @returns The resolved horizontal side. | ||
| * WARNING : Do not use this function to swap elements that use css logical properties. They will get double-mirrored. |
Contributor
|
🚀 Styleguide deploy preview ready! Preview URL: https://69f108bfa9215021933d9b4f--gamut-preview.netlify.app |
dreamwasp
added a commit
that referenced
this pull request
Apr 28, 2026
* fix: popover, need to test invertAxis * tooltip * fix: Address followups for ToolTip bugs RTL (#3330) * update story and mdx * restore RTL beaks * add horizontal alignments story * ToolTip text update * applied Amy's feedback * fix(Popover): addressing left/right beak (#3332) * addressing corner beaks for popover alignment and tests * tweak docs * test Popover (#3334) * test Popover * linted * remove log props * testing better tooling * beak * resolve beaks * SB cleanup * remove thigns we do not need * linted! * ok now fixed --------- Co-authored-by: Kenny Lin <kenny.lin.91@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
PR Checklist
Testing Instructions
Don't make me tap the sign.
PR Links and Envs