Fix PHP 8+ TypeError when service_data is a non-array value in localize_dashboard_app#1057
Open
Copilot wants to merge 3 commits intodevelopmentfrom
Open
Fix PHP 8+ TypeError when service_data is a non-array value in localize_dashboard_app#1057Copilot wants to merge 3 commits intodevelopmentfrom
Copilot wants to merge 3 commits intodevelopmentfrom
Conversation
…rray (PHP 8+) Add is_array() guard after retrieving service_data to normalize non-array values to empty string, preventing fatal "Cannot access offset of type string on string" error on PHP 8+. Agent-Logs-Url: https://github.com/Codeinwp/optimole-wp/sessions/787a8a46-2d70-41ae-9538-6ab319b47136 Co-authored-by: kushh23 <110405452+kushh23@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix fatal error on accessing service_data offset in admin.php
Fix PHP 8+ TypeError when service_data is a non-array value in localize_dashboard_app
Apr 23, 2026
Collaborator
… navigation timeout All E2E failures were Firefox page-load timeouts against the external test server with the previous 30s limit. Also improve service_data fallback to use empty array instead of empty string for type consistency. Agent-Logs-Url: https://github.com/Codeinwp/optimole-wp/sessions/1ae8a7b0-0ced-417f-91c5-681d77eb0704 Co-authored-by: kushh23 <110405452+kushh23@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
playwright.config.tsfrom 30s to 60snavigationTimeout: 45000for better handling of slow page loadsservice_datafallback from''to[]for type consistency