Re-order env-vars so they are set after env-vars set in dependencies

[ptsOSL]

It seems sensible that the env-vars set by dependencies would be overwritten by the modulefile for the module you are loading.

Giles did highlight that there may be situations where your dependencies require env-vars defining before they are module loaded, such as when env-vars are needed to load the module correctly. But currently he is not doing this.

[MJGaughran]

I'm not aware of anything that would require environment variables to be set before loading; I suspect that would be considered a poorly-constructed modulefile, as they should be including any dependencies (including env vars) automatically when you load them.

But @gilesknap, if you have any examples from DLS that would be appreciated.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.64%. Comparing base (2f5d1b5) to head (2d84cae).

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #51   +/-   ##
=======================================
  Coverage   75.64%   75.64%           
=======================================
  Files          25       25           
  Lines         936      936           
=======================================
  Hits          708      708           
  Misses        228      228           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gilesknap]

@MJGaughran no I don't know of any modules that require environment set when loading. As you say that would not be a great idea anyway.