Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
=======================================
Coverage 75.64% 75.64%
=======================================
Files 25 25
Lines 936 936
=======================================
Hits 708 708
Misses 228 228 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Later stages rely on a uv managed python install which wont be installed if uv finds a suitable system installed python version.
MJGaughran
reviewed
Apr 24, 2026
MJGaughran
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to the latest copier template which includes:
In order to get the new Dockerfile building the images correctly I had to add quite a few extra installs such as git and ca-certificates. However both the developer container and the runtime container now seem to be working properly for me.
To test the runtime container I built the Dockerfile into a sif file and then ran:
apptainer run --bind /scratch:/scratch:rw deploy-tools.sif sync -v --from-scratch /scratch/zrv91478/vscode/deploy-tools/demo-output2/ /scratch/zrv91478/vscode/deploy-tools-config/configuration/
This worked as expected, so I'm hopeful that this is good now.