Open
Conversation
ZohebShaikh
reviewed
Mar 17, 2026
ZohebShaikh
reviewed
Mar 17, 2026
ZohebShaikh
reviewed
Mar 17, 2026
Contributor
ZohebShaikh
left a comment
ZohebShaikh
left a comment
There was a problem hiding this comment.
Looks good only few minor things
ZohebShaikh
reviewed
Mar 17, 2026
Alexj9837
force-pushed
the
numtracker_graylog
branch
from
bda4336 to
831a990
Compare
- Extract GraylogOptions into its own struct, independent of TracingOptions - Remove .vscode/launch.json (to be added in a separate PR) - Remove version/build additional_field calls from Graylog logger - Switch let-else to if-let in init_graylog - Warn when Graylog URL has no port rather than silently defaulting - Add reconnect loop so dropped connections recover automatically - Improve connection error messages to distinguish DNS failure from TCP errors
Alexj9837
force-pushed
the
numtracker_graylog
branch
from
831a990 to
0a86a82
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
==========================================
- Coverage 76.35% 76.19% -0.16%
==========================================
Files 13 13
Lines 1937 2046 +109
==========================================
+ Hits 1479 1559 +80
- Misses 458 487 +29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tpoliaw
requested changes
Mar 30, 2026
Collaborator
tpoliaw
left a comment
tpoliaw
left a comment
There was a problem hiding this comment.
Looks pretty good, thanks for looking at it. A couple of changes could make the error handling a bit cleaner and keep it more consistent with what is already there though.
| async fn main() -> Result<(), Box<dyn Error>> { | ||
| let args = Cli::init(); | ||
| let _ = logging::init(args.log_level(), args.tracing()); | ||
| let _ = logging::init(args.log_level(), args.tracing(), &args.graylog); |
Collaborator
There was a problem hiding this comment.
We should probably handle errors here. Currently if any log setup fails you get no output and debugging why is a pain.
Alexj9837
force-pushed
the
numtracker_graylog
branch
3 times, most recently
from
498354e to
59d5002
Compare
Alexj9837
force-pushed
the
numtracker_graylog
branch
from
59d5002 to
926a966
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#252
Summary
tracing-gelflayer to ship structured logs to a Graylog instance via GELF TCP--graylog <URL>and--logging-level <LEVEL>CLI flags (also viaNUMTRACKER_GRAYLOG/NUMTRACKER_GRAYLOG_LOG_LEVELenv vars)numtracker.graylog.enabled/host/levelvalues