Handle missing contacts provider gracefully when loading avatars#754
Open
striker314 wants to merge 1 commit intoFossifyOrg:mainfrom
Open
Handle missing contacts provider gracefully when loading avatars#754striker314 wants to merge 1 commit intoFossifyOrg:mainfrom
striker314 wants to merge 1 commit intoFossifyOrg:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change(s)
What changed and why
App is throwing these errors:
Failed to find provider info for org.fossify.commons.contactsproviderRight when that happens, Fossify also starts spamming Glide image-load failures in the same area of the log, which looks like contact/avatar loading is failing while the thread view opens.
The contacts provider authority does not seem to be registered in the app, so we should gracefully handle when it is not.
Tests performed
Built and installed onto S25 Ultra:
One UI: v8.0
Android: v16
Closes the following issue(s)
Does not address reported issues. Was hopeful this would resolve issues/204, but the java exception popup still happens. Will continue to debug and provide further code changes if possible to continue chasing that issue.
Checklist
CHANGELOG.md(if applicable).