DAP20 Capstone - Issue creation and Close, Slack and Email notification for testsPython#45
Open
emsbc wants to merge 6 commits intoFullStackWithLawrence:mainfrom
Open
DAP20 Capstone - Issue creation and Close, Slack and Email notification for testsPython#45emsbc wants to merge 6 commits intoFullStackWithLawrence:mainfrom
emsbc wants to merge 6 commits intoFullStackWithLawrence:mainfrom
Conversation
Feature/ci notifications
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Type of Change
Changes
.github/workflows/testsPython.ymlworkflow_dispatchinput to parameterise failure notification recipient(s) — accepts comma-separated email addressesif: always()to thenotificationsjob — without this GitHub skips the job when upstream tests fail, defeating the purposepermissions: issues: writeto allow the job to create and close GitHub Issuesenvblock mapping secrets to environment variables — GitHub Actions does not allowsecretscontext in step-levelifexpressionsSLACK_WEBHOOK_URLsecret is absent)workflow_dispatchinput with fallback toNOTIFY_EMAILsecretbug-labelled issue on failureapp/settings.pyMYSQL_PORTto useorinstead of a default argument so that an empty string passed from GitHub Actions secrets falls back to3306correctlyMakefileACTIVATE_VENVfor Windows/Git Bash: addedsourceprefix and changed backslashes to forward slashesmise.toml(new file).venvonmise installinit,init-dev,test,coverage,lint,pre-commit,tear-down,analyze,release)doc/CI_NOTIFICATIONS_TESTING_GUIDE.md(new file)Testing
See doc/CI_NOTIFICATIONS_TESTING_GUIDE.md