fix(ConvertBrepSection): change the way we deal with model boundaries…

[BenPinet]

… in brep to section conversions

[github-actions]

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 6 concern(s)

• src/geode/model/helpers/convert_brep_section.cpp:83:9: warning: [google-explicit-constructor]

  single-argument constructors must be marked explicit to avoid unintentional implicit conversions

     83 |         SectionExtruder( const geode::Section& section )
        |         ^
        |         explicit 

• src/geode/model/helpers/convert_brep_section.cpp:201:32: warning: [performance-unnecessary-copy-initialization]

  the const qualified variable 'name' is copy-constructed from a const reference; consider making it a const reference

    201 |                 if( const auto name = model_boundary.name() )
        |                                ^
        |                               &

• src/geode/model/helpers/convert_brep_section.cpp:244:17: warning: [cppcoreguidelines-pro-type-member-init]

  uninitialized record type: 'pointids'

    244 |                 std::array< geode::index_t, 4 > pointids;
        |                 ^                                       
        |                                                         {}

• src/geode/model/helpers/convert_brep_section.cpp:346:17: warning: [cppcoreguidelines-pro-type-member-init]

  uninitialized record type: 'pointids'

    346 |                 std::array< geode::index_t, 6 > pointids;
        |                 ^                                       
        |                                                         {}

• src/geode/model/helpers/convert_brep_section.cpp:346:45: warning: [cppcoreguidelines-avoid-magic-numbers]

  6 is a magic number; consider replacing it with a named constant

    346 |                 std::array< geode::index_t, 6 > pointids;
        |                                             ^

• src/geode/model/helpers/convert_brep_section.cpp:347:33: warning: [readability-identifier-length]

  variable name 'p0' is too short, expected at least 3 characters

    347 |                 for( const auto p0 : geode::LRange{ 3 } )
        |                                 ^

Have any feedback or feature suggestions? Share it here.