fix(LoaderComponents): Add loader and new logic for components loader#373
Open
fix(LoaderComponents): Add loader and new logic for components loader#373
Conversation
…tions/OpenGeodeWeb-Front into fix/AddLoaderTreeview
…tions/OpenGeodeWeb-Front into fix/AddLoaderTreeview
…b-Front into fix/AddLoaderTreeview
…tions/OpenGeodeWeb-Front into fix/AddLoaderTreeview
…tions/OpenGeodeWeb-Front into fix/AddLoaderTreeview
BotellaA
reviewed
Apr 23, 2026
Member
BotellaA
left a comment
BotellaA
left a comment
There was a problem hiding this comment.
beaucoup trop de code pour ma review... @JulienChampagnol je te laisse le verdict 😉
…tions/OpenGeodeWeb-Front into fix/AddLoaderTreeview
…tions/OpenGeodeWeb-Front into fix/AddLoaderTreeview
…tions/OpenGeodeWeb-Front into fix/AddLoaderTreeview
…tions/OpenGeodeWeb-Front into fix/AddLoaderTreeview
…tions/OpenGeodeWeb-Front into fix/AddLoaderTreeview
| import { useTreeviewStore } from "@ogw_front/stores/treeview"; | ||
| const LOADER_DELAY_MS = 50; | ||
|
|
||
| const { id: viewId } = defineProps({ id: { type: String, required: true } }); |
Member
There was a problem hiding this comment.
Suggested change
| const { id: viewId } = defineProps({ id: { type: String, required: true } }); | |
| const { id } = defineProps({ id: { type: String, required: true } }); |
Même si c'était déjà là, je pense pas que viewId soit très parlant, Y a viewId dans le viewer ça porte à confusion
| options = {}, | ||
| } = defineProps({ | ||
| items: { type: Array, required: true }, | ||
| opened: { type: Array }, |
Member
There was a problem hiding this comment.
Suggested change
| opened: { type: Array }, | |
| opened: { type: Array, required: false, default: [] }, |
Même commentaire pour les autres
| const { item, isLeaf = undefined } = defineProps({ | ||
| item: { type: Object, required: true }, | ||
| showTooltip: { type: Boolean, default: false }, | ||
| isLeaf: { type: Boolean }, |
Member
There was a problem hiding this comment.
Suggested change
| isLeaf: { type: Boolean }, | |
| isLeaf: { type: Boolean, required: false: default: undefined }, |
| @@ -1,37 +1,62 @@ | |||
| <script setup> | |||
| const { item, showTooltip } = defineProps({ | |||
| const { item, isLeaf = undefined } = defineProps({ | |||
Member
There was a problem hiding this comment.
Suggested change
| const { item, isLeaf = undefined } = defineProps({ | |
| const { item, isLeaf } = defineProps({ |
|
|
||
| const { | ||
| items, | ||
| opened = [], |
Member
There was a problem hiding this comment.
Suggested change
| opened = [], | |
| opened, |
Member
There was a problem hiding this comment.
Dans ce cas à mettre dans utils
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.notion.so/Fix-loader-components-34a68b997d3b80e398c5ce8d84ee5983?source=copy_link