Skip to content

Service mode parser response and security improvements#1951

Open
amangalampalli-ks wants to merge 2 commits intoreleasefrom
service-mode-improvements
Open

Service mode parser response and security improvements#1951
amangalampalli-ks wants to merge 2 commits intoreleasefrom
service-mode-improvements

Conversation

@amangalampalli-ks
Copy link
Copy Markdown
Contributor

Summary

  • Improve tree -s -v response parsing to correctly handle teams and users in shared folder permissions
  • Improve service mode security: API key comparison, refactored IP allow/deny logic with proper CIDR and range support, and conditional ProxyFix only when behind a reverse proxy (ngrok/cloudflare)

Changes

  • Use hmac.compare_digest for API key validation
  • Rewrite is_allowed_ip with clear deny-first logic, CIDR network support, and strict IP parsing
  • Apply ProxyFix only when behind a proxy;
  • Structured parsing for tree share permissions (teams/users brackets)
  • Add share-report and tree to integration service commands

* Improve security checks in service mode

* Update tree -s -v response with better structure

* Add share-report and ls command in slack and team setup command list

* Fix flag in convert and convert-all

* Add tree command in team and slack setup command list
@amangalampalli-ks amangalampalli-ks force-pushed the service-mode-improvements branch from 8822d7e to 654ed63 Compare April 15, 2026 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant