Skip to content

Fix missing opencsd header in trc_tgt_mem_access_i.h#87

Open
c722996 wants to merge 1 commit intoLinaro:masterfrom
c722996:fix-deps
Open

Fix missing opencsd header in trc_tgt_mem_access_i.h#87
c722996 wants to merge 1 commit intoLinaro:masterfrom
c722996:fix-deps

Conversation

@c722996
Copy link
Copy Markdown

@c722996 c722996 commented Apr 17, 2026

No description provided.

@mikel-armbb
Copy link
Copy Markdown
Contributor

Please provide context and example of failing use case for this. The library compiles correctly without this change.

@c722996
Copy link
Copy Markdown
Author

c722996 commented Apr 21, 2026

Hi Mike,

While implementing a custom memory accessor, I encountered compilation failures when including trc_tgt_mem_access_i.h in isolation. The build fails due to undefined types, specifically ocsd_mem_space_acc_t and ocsd_err_t.

Currently, the header relies on transitive includes and violates the "Include What You Use" (IWYU) principle. This patch explicitly includes the missing dependencies (e.g., ocsd_if_types.h) to make the header fully self-contained and prevent future build breaks.

@mikel-armbb
Copy link
Copy Markdown
Contributor

The interface applies to mappers not accessors.
Use the main trc_mem_acc.h when developing custom accessors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants