ini: update all configs with a quote at the start of a value#3947
Draft
BsAtHome wants to merge 1 commit intoLinuxCNC:masterfrom
Draft
ini: update all configs with a quote at the start of a value#3947BsAtHome wants to merge 1 commit intoLinuxCNC:masterfrom
BsAtHome wants to merge 1 commit intoLinuxCNC:masterfrom
Conversation
This was referenced Apr 18, 2026
BsAtHome
force-pushed
the
fix_ini-config-quotes
branch
from
38077a9 to
abf22d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Single or double quotes starting a value in an ini-file will now be interpreted by the new ini-parser as a quoted string. You must escape the quotes or use double/single quotes to embed single/double quotes. Note that this only happens when a single or double quote is found at the start of a value. Otherwise, the whole value is just taken and used as-is.
This PR fixes all existing configs' ini-files where such quotes are used and uses one type of quotes to embed the other:
"xyz" => '"xyz"' and 'xyz' => "'xyz'". It also updates the inivalue program (and test) to print the values properly when the--contentoption is specified, adding quotes around quoted strings.This fixes #3946 for all existing in-tree configs. User configs need manual intervention for now. The update_ini program needs updating (see #3704) to update quoted strings.