Reduce map rebuild work during live tracking#12
Draft
robekl wants to merge 9 commits intoMeshMapper:devfrom
Draft
Reduce map rebuild work during live tracking#12robekl wants to merge 9 commits intoMeshMapper:devfrom
robekl wants to merge 9 commits intoMeshMapper:devfrom
Conversation
Contributor
|
Hey! Great optimization,
Also, are you on our Discord? |
…markers changed from purple to cyan, RX markers changed from blue to purple. TX (green) and Trace (cyan) were already aligned. Applies to map markers, noise floor chart, status bar chips, log screen filters, and home screen stats.
…markers changed from purple to cyan, RX markers changed from blue to purple. TX (green) and Trace (cyan) were already aligned. Applies to map markers, noise floor chart, status bar chips, log screen filters, and home screen stats. - Map coverage dots now draw in chronological order instead of by category. When your path crosses over itself, the most recent ping always renders on top regardless of type. - Reduced the thick white outline on map coverage dots to a subtle semi-transparent border, improving readability when markers cluster together. Repeater ID markers retain their original styling.
…nds (TX/RX pings) would work reliably in some sessions but not at all in others.
…nd Active/Hybrid mode buttons are now hidden instead of showing disabled "Zone Full" states. The Passive mode button expands to fill the full control panel width. Applies to portrait, compact, and landscape layouts.
Contributor
Author
|
That all makes sense. PR updated. |
Collaborator
|
please resolve conflicts, likely of note is that dev is now formatted with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The live map path rebuilt from broad app-state notifications, including frequent timer-driven updates unrelated to map data. It also recreated network tile providers during rebuilds, causing avoidable work during active tracking.
Change
Narrowed the map's subscriptions to map-relevant state only, introduced a dedicated revision signal for map data mutations, and reused tile providers instead of recreating them on each rebuild.
Why This Fixes It
The map now rebuilds when map inputs actually change rather than on every unrelated provider notification. Reusing tile providers also avoids repeated client allocation. Together, those changes reduce runtime churn on the hottest UI path during wardriving.