Open
Conversation
Contributor
|
Nice catch! Before I merge this, could you also add
The 15s self-stop makes it low-risk, but since you're already fixing this timer's lifecycle it'd be good to make it complete in one PR. Let me know if you have time to add that! |
Contributor
Author
Done! |
Collaborator
|
can you pull and run dart format then commit the formatting changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The manual ping cooldown timer was created and used for periodic UI updates, but it was not disposed when app state was torn down. That leaves a live timer behind after provider disposal, which is a lifecycle leak and can cause unnecessary work after teardown.
Change
Added explicit disposal for the manual ping cooldown timer during app-state cleanup.
Why This Fixes It
The timer now follows the same ownership and teardown path as the other countdown timers. That removes the leaked periodic callback and ensures no timer-driven updates survive provider disposal.