Fixes setting user on third party Add-Ons for new developers#386
Open
duckduckgrayduck wants to merge 1 commit intomasterfrom
Open
Fixes setting user on third party Add-Ons for new developers#386duckduckgrayduck wants to merge 1 commit intomasterfrom
duckduckgrayduck wants to merge 1 commit intomasterfrom
Conversation
eyeseast
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alex G. from Datasette couldn't link the Github app to his user account on DocumentCloud to test an Add-On. The user was listed as "None" in the admin panel for the linked Add-On and cannot update. I saw that one other user had the same problem.
documentcloud/addons/signals.py line 23
if acct["provider"] != "github_app":
continue
documentcloud/documentcloud/addons/signals.py
Line 23 in f3b387c
DocumentCloud's update_github_account signal handler filters incoming Squarelet user_update payloads for social accounts with provider == "github_app" and uses them to set GitHubAccount.user. On January 10, 2025, a Squarelet migration renamed that provider from "github_app" to "github", so the filter never matches anymore. The handler silently skips every GitHub social account, GitHubAccount.user is never populated for new third-party users, and AddOn.user (which reads through github_account.user) returns None.
Migration that broke this:
MuckRock/squarelet@e7ff9eb