Fix Fortran Wrapper Parameter Passing Bug in barrier and forget Functions#116
Open
kellih wants to merge 3 commits intoMxUI:masterfrom
Open
Fix Fortran Wrapper Parameter Passing Bug in barrier and forget Functions#116kellih wants to merge 3 commits intoMxUI:masterfrom
kellih wants to merge 3 commits intoMxUI:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Fortran wrapper interfaces for barrier_* and forget_* functions incorrectly used the value attribute on scalar parameters (time values and reset flags), causing segmentation faults when called from Fortran code. The C++ implementation expects pointers (double *t, int *reset_log), but Fortran's value attribute passes by-value instead of by-reference.
Additional bug uncovered by commit 3ffd697 in CMakeLists.txt where MPI REQUIRED was not included for Fortran wrapper.
Scope:
Affects 90 function interfaces across all three spatial dimensions:
Changes Made:
unit_test.f90: Added barrier calls after commit and forget calls after fetch for 1D, 2D, and 3D interfacesunit_test_multi.f90: Added barrier/forget loops for all dimensions in multi-interface testBackward Compatibility:
No API changes - this is a pure bug fix correcting the ABI between Fortran and C++.
Resolves issue #115