Open
Conversation
sleeepyjack
added
P1: Should have
sleeepyjack
commented
Apr 17, 2026
sleeepyjack
commented
Apr 17, 2026
sleeepyjack
force-pushed
the
worktree-128bit-atomics
branch
from
1cbf8bb to
4a6ccc2
Compare
sleeepyjack
force-pushed
the
worktree-128bit-atomics
branch
from
4a6ccc2 to
6a2a1d2
Compare
PointKernel
added
Needs Review
PointKernel
reviewed
Apr 22, 2026
| // wait to ensure that the write to the value part also took place | ||
| this->wait_for_payload(slot_ptr->second, this->empty_value_sentinel()); | ||
| } | ||
| this->maybe_wait_for_payload(slot_ptr); |
Member
There was a problem hiding this comment.
This makes code much cleaner but the readability is getting worse IMO. a weak approval :)
PointKernel
approved these changes
Apr 23, 2026
Member
PointKernel
left a comment
PointKernel
left a comment
There was a problem hiding this comment.
128-bit now in place 🔥
@sleeepyjack can you please update the PR descriptions to reflect the changes brought by this PR? Otherwise looks great to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.