fix: github updater provider with private repositories

[andreamarelli]

Using GITHUB_RELEASE_TOKEN instead of GH_TOKEN enable the possibility to publish to a private repository,

See references in electron-build documentation and code.

At the moment the app-update.yml file in the electron builder does not receive any token, which is fine for checking for updates from a public repository, but not from a private one where a token is required instead.

[SRWieZ]

Hi, thank you for looking into that.

Currently, this appears to be a breaking change.

I also don't fully understand the solution as you do. For me, GH_TOKEN is used to check for releases on a private repository, while GITHUB_RELEASE_TOKEN is the token that has write access to publish the app to those releases.

If GITHUB_RELEASE_TOKEN is defined, it will be used instead of (GH_TOKEN or GITHUB_TOKEN) to publish your release. - e.g. mac: export GITHUB_RELEASE_TOKEN= - the GITHUB_TOKEN will still be used when your app checks for updates, etc. - you could make your GITHUB_TOKEN “Read-only” when creating a fine-grained personal access token, and “Read and write” for the GITHUB_RELEASE_TOKEN. - “Contents” fine-grained permission was sufficient. (at time of writing - Apr 2024)

You will also need to change config/nativephp.php.

Please update the PR to support both, and we will need another PR for the documentation to clarify the situation.