Skip to content

[18.0][ADD] webservice_base: lighter version of webservice module#102

Open
dreispt wants to merge 3 commits intoOCA:18.0from
ursais:18-dr-webservice-light
Open

[18.0][ADD] webservice_base: lighter version of webservice module#102
dreispt wants to merge 3 commits intoOCA:18.0from
ursais:18-dr-webservice-light

Conversation

@dreispt
Copy link
Copy Markdown
Member

@dreispt dreispt commented Jun 15, 2025

Refactoring of webservice module to remove dependency on component.
Depends on (and includes) #101

New commits:

  • [ADD] webservice_base

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hi @etobella,
some modules you are maintaining are being modified, check this out!

@dreispt dreispt force-pushed the 18-dr-webservice-light branch from 9bf6091 to 0feed39 Compare June 15, 2025 20:22
@dreispt dreispt changed the title [18.0] webservice_base[_auth]: lighter version of webservice module [18.0] webservice_base[_oauth]: lighter version of webservice module Jun 15, 2025
@dreispt dreispt force-pushed the 18-dr-webservice-light branch 2 times, most recently from cb66205 to aab520e Compare June 15, 2025 20:30
@dreispt dreispt force-pushed the 18-dr-webservice-light branch from aab520e to 166b3bf Compare June 15, 2025 20:36
@dreispt dreispt changed the title [18.0] webservice_base[_oauth]: lighter version of webservice module [18.0][ADD] webservice_base: lighter version of webservice module Jun 15, 2025
Comment thread webservice_base/readme/DESCRIPTION.md Outdated
@dreispt dreispt force-pushed the 18-dr-webservice-light branch from 166b3bf to 7dd2970 Compare June 16, 2025 06:50
Refactoring of `webservice` module to remove dependency on `component`.
@dreispt dreispt force-pushed the 18-dr-webservice-light branch from 7dd2970 to 5f34ad6 Compare June 16, 2025 06:51
@ivs-cetmix
Copy link
Copy Markdown
Member

Hi @dreispt , is there any functional documentation available for this module?

@dreispt
Copy link
Copy Markdown
Member Author

dreispt commented Dec 15, 2025

@ivs-cetmix see #119

@flotho
Copy link
Copy Markdown
Member

flotho commented Apr 15, 2026

Hi,
Thanks for this PR,
Any chance to rebase to trigger CI/CD ?



class WebserviceRequestAdapter(models.AbstractModel):
_name = "webservice.request.adapter"
Copy link
Copy Markdown
Contributor

@simahawk simahawk Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I don't like this implementation.
It does not support different adapters for different use cases.
It should be possible to register specific adapters for the protocol.
Plus, the methods here should be renamed to not clash w/ core methods (existing or new to come).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two approaches used in core Odoo to support adapter/plugin like features:

  1. Adapter specific logic guarded by an "if" statement in extension methods.
  2. Base method routes to adapter specific logic using dynamic calls to methods.

The 1. approach has some limitations; the 2. approach is the de facto standard, as seen in delivery carriers and , payment providers.

I can work on expanding this idea to include the routing mechanism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants