Skip to content

Resize Sprite & Fixed the <experimental/filesystem> Warning #56

Open
baderouaich wants to merge 3 commits intoOneLoneCoder:masterfrom
baderouaich:master
Open

Resize Sprite & Fixed the <experimental/filesystem> Warning #56
baderouaich wants to merge 3 commits intoOneLoneCoder:masterfrom
baderouaich:master

Conversation

@baderouaich
Copy link
Copy Markdown

@baderouaich baderouaich commented Dec 16, 2019

  • Added function Sprite::Resize(int32_t newWidth, int32_t newHeight); to resize a loaded sprite using Nearest Neighbor Image Scaling Algorithm.
  • Fixed Warning:
    std::experimental::filesystem is deprecated by Microsoft and will be REMOVED. It is superseded by the C++17  header providing std::filesystem. You can define _SILENCE_EXPERIMENTAL_FILESYSTEM_DEPRECATION_WARNING to acknowledge that you have received this warning.

- Added function Resize(int32_t newWidth, int32_t newHeight); to resize a loaded sprite using Nearest Neighbor Image Scaling Algorithm. - Fixed Warning: std::experimental::filesystem is deprecated by Microsoft and will be REMOVED. It is superseded by the C++17 <filesystem> header providing std::filesystem. You can define _SILENCE_EXPERIMENTAL_FILESYSTEM_DEPRECATION_WARNING to acknowledge that you have received this warning.
Resize Sprite & Fixed the <experimental/filesystem> Warning
@OneLoneCoder
Copy link
Copy Markdown
Owner

Thanks, these two are interesting. If I may ask what is your compiler configuration, because if you are using up to date MSVC2017 or 2019 you should not see the deprecation message simply because of your compiler configuration.

Regarding the sprite sizing, I'm currently starting to plan out PGE2.0 so it may appear in there. Anyway, I dont close off PRs because its useful for others to see and study them.

@baderouaich
Copy link
Copy Markdown
Author

Hello there,
I am using the MSVC 14.24.28314 | _MSC_VER == 1924 | Visual Studio 16 2019.
as you mentioned, its due the outdated compiler.
i would recommend a flag definition for the outdated MSVC compiler users.

Can't wait to start another year with the new version of PGE!
i'd also love to see mobile support with OpenGL-ES for Android & IOS. will be alot of fun.

@ghost ghost mentioned this pull request Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants