Add pagination to credentials and project credentials page#4672
Open
sharleenawinja wants to merge 1 commit intoOpenFn:mainfrom
Open
Add pagination to credentials and project credentials page#4672sharleenawinja wants to merge 1 commit intoOpenFn:mainfrom
sharleenawinja wants to merge 1 commit intoOpenFn:mainfrom
Conversation
Author
|
@midigofrank could you please review this PR when you have a moment? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds pagination to the credentials, keychain credentials, and OAuth clients tables on the credentials list pages (10 items per page, with Previous/Next control). OAuth clients are now in a collapsible section, collapsed by default. Tables are ordered: credentials first, keychain credentials second, OAuth clients last.
Closes #4301
Validation steps
Go to
/credentialswith more than 10 credentials — confirm the table paginatesConfirm the OAuth Clients section is collapsed by default and the toggle shows/hides it.
If there are more than 10 OAuth clients, expand the section and confirm pagination works.
Verify the same behaviour on Project Settings → Credentials.
Additional notes for the reviewer
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Pre-submission checklist
/reviewwith Claude Code)
(e.g.,
:owner,:admin,:editor,:viewer)