Skip to content

Fix edit remove snippets #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kuuuube wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix edit remove snippets #54

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f25829d
Fix edit snippet
Kuuuube Apr 15, 2026
d5d8b14
Use exact match of id and title for remove snippet
Kuuuube Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions src/commands/snippets.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,12 @@ pub async fn edit_snippet(
ctx: Context<'_>,
#[autocomplete = "autocomplete_snippet"]
#[description = "The snippet's id"]
id: String,
#[rename = "id"]
id_and_title: String,
#[description = "The snippet's title"] title: Option<String>,
#[description = "The snippet's content"] content: Option<String>,
) -> Result<(), Error> {
match get_snippet_lazy(&ctx, &id) {
match get_snippet(&ctx, &id_and_title) {
Some(mut snippet) => {
if let Some(title) = title {
snippet.title = title;
Expand All @@ -118,7 +119,8 @@ pub async fn edit_snippet(

{
let mut rwlock_guard = ctx.data().state.write().unwrap();
rwlock_guard.snippets.push(snippet.clone());
let editing_snippet = rwlock_guard.snippets.iter_mut().find(|s| s.format_output().eq(&id_and_title)).unwrap();
*editing_snippet = snippet.clone();
println!("Snippet edited '{}: {}'", snippet.title, snippet.content);
rwlock_guard.write();
}
Expand All @@ -128,7 +130,7 @@ pub async fn edit_snippet(
}
None => {
let title = &"Failed to edit snippet";
let content = &&format!("The snippet '{id}' does not exist");
let content = &&format!("The snippet '{id_and_title}' does not exist");
respond_err(&ctx, title, content).await;
}
};
Expand All @@ -142,15 +144,16 @@ pub async fn remove_snippet(
ctx: Context<'_>,
#[autocomplete = "autocomplete_snippet"]
#[description = "The snippet's id"]
id: String,
#[rename = "id"]
id_and_title: String,
) -> Result<(), Error> {
match get_snippet_lazy(&ctx, &id) {
match get_snippet(&ctx, &id_and_title) {
Some(snippet) => {
remove_snippet_confirm(&ctx, &snippet).await?;
}
None => {
let title = &"Failed to remove snippet";
let content = &&format!("The snippet '{id}' does not exist");
let content = &&format!("The snippet '{id_and_title}' does not exist");
respond_err(&ctx, title, content).await;
}
}
Expand Down Expand Up @@ -234,7 +237,7 @@ impl Embeddable for Snippet {
}

// Exact matches the snippet id and name.
fn _get_snippet(ctx: &Context<'_>, id: &str) -> Option<Snippet> {
fn get_snippet(ctx: &Context<'_>, id: &str) -> Option<Snippet> {
let data = ctx.data();
let rwlock_guard = data.state.read().unwrap();

Expand Down