Migrate back to mypy and enable typechecking in CI#2595
Open
VeckoTheGecko wants to merge 5 commits intoParcels-code:mainfrom
Open
Migrate back to mypy and enable typechecking in CI#2595VeckoTheGecko wants to merge 5 commits intoParcels-code:mainfrom
VeckoTheGecko wants to merge 5 commits intoParcels-code:mainfrom
Conversation
This reverts commit 831c43d.
Add file exclusions (to be worked on then removed)
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
xref #2540
After trying out
tysome more, I think it's best if we go for mypy. It has better support in the ecosysytem, and ty was flagging a lot of 'errors' within xarray internals causing noise.Changes:
mypyin CI (i.e., we will get red crosses if it fails)Checklist