Skip to content

Fix various compare tab issues#9780

Merged
LocalIdentity merged 11 commits intoPathOfBuildingCommunity:devfrom
oboking:fix/compare-tab-fixes
Apr 18, 2026
Merged

Fix various compare tab issues#9780
LocalIdentity merged 11 commits intoPathOfBuildingCommunity:devfrom
oboking:fix/compare-tab-fixes

Conversation

@oboking
Copy link
Copy Markdown
Contributor

@oboking oboking commented Apr 18, 2026

Description of the problem being solved:

  • Imbued support are now included as support gems in the compared "Skills" tab.
  • An incorrect set of config options were being shown even when ineligible options should have been hidden. Also removed the map config group options from the Compared config. "Configurations" tab.
  • Overlapping text in "Calcs" tab for Auras/Buffs & Curses/Debuffs
  • Overlapping text in "Config" tab for interactable elements
  • Infinity scrolling in "Summary", "Skills", and "Items", tabs.
  • Horizontal scrolling was needed in the "Items" tab for the wide "static" content on small screen sizes
  • Move to a content driven layout column split with horizontal scrollbars rather than a 50/50 split

Steps taken to verify a working solution:

  • Added imbued supports and confirmed the inclusion and highlighting works as expected in the "Skills" tab in the "Compare" tab.
  • Added a huge number of buffs to a build to make sure everything is listed without any overlap/occlusion in the "Calcs" tab.

Link to a build that showcases this PR:

eNrNXFtz27YSfk5_BUfv0YW6ROnY7ciWHXvGjnVMJznnqQORkIQGIlQQtK3--i4AXiVTBkieMycPLQjhW-wusItdXHz2--uWOs-YR4SF551Bt99xcOizgITr8863p-uP087vv_1ytkBi87C6iAmVv_z2y4czVXZ8iqLoK9ri847nA4mOIxBfY_E9pTj8AyjuUCg2mIX36E_Gv7DgvPOVhbhQT8JSvb9BHPkC8zv8jOksFuyeBdCF4DH8ukRhQETadotI6DH_JxZfOIt3IEPHoRKmSijycRhc5lxq0DPBL5rk7f3i4fGpAxJ9OFtQtMfcE0g4EfznvDMDxaA1viECIIjG0H4wnoy6U_fTuNM7ibmIeSTmaAvFDDscuJ-7k3El1NthHGSt3e6oquGC46vVCvuCPONLTsTlBoV-3s-kCmfb9j6mguwowTyXv1vJ_s0R8UG_X9X4iQlE5wsvV86n8bg7nk5OA1g-EpWkfxCxuaCgShvyEnS7DonANqgFIxELi4jBwO1OPrvDdxDlieG64-5wOjrJ3HFXw-lk2P30qT_pT99TWonD_rQ7gM6qUZcxpWDlRVClsh9xhPkzEqTMW2X7S7ZdkvBgbN4X5B6F6JJF-eiP-6eaLjAHuxclxHsAD_sMXEURMjHp5G1oJfKOrLB5SytBEoAtN_XkuPJM21kTrsfQI1iUWUuPxdSwpcg9n3vCBv4qNvxcOYvn-NWMXLHhoHrBuA2FGb1iwxP05viZCbWKv6cY5Viubha5PU67o9F42HfdT8PxsFIDi80-Ij6i9-iVbOMtLBlP6CcODSzujqw3IgS3VAmt7PSacGyPumQ0qIHaIBZVwar1Iu3QQAkQIfi_yra3oW9m3N9Crjx0IbCYnAQ8gsnJEGZJsSEi7yIxXJP1X3e1xmHS395MnDuM_c0XCPkekcBmrt1gyVBqlW2N1CobvqHWj4P-0AxyqKaPbn9yCvm2ngbdwSmQpaauQszXe29DMA3sWqeMXaKdgUOVmi6ijTRe7s5q0hShlir5gXhgtuzY8vSMoqKXHUxOq0s3N5ubGAJfAAT4IBTvV-cS7E-ZSVA72IxvWcwNB1w3NhIgXSB0hPyIg9g3W5GyhOiCQjZoKkaGAj4ptYLOhED-zzkL1sZKU51YIcr8efFuB05EzgZTAnLtgxidRMUA4P3GDzCTjQxarpLG9PPGxvSzZd-4kwOEuSRy5T7o5ePEpLlxF9lo3oOn2MISoDL-e5a7mUqXfg05mVGCpRqWM75qY2MvwPlG7thEdq0hwsmjmkpWOA7_3hvTLzU36uAqDGIu7cC4j0PEW908kS140SiaI4GcCCPub-5glK8RpUuw-PNOp1Arv4IkbP6OOEGhGKidp4NKV1VGaqPqmlCB-RzQkpOU27Oe2lKTpUtE_UjxchvuYsk7V_txV9fXV5dPt9-vOk6odrO2JPL_WMarldzMStjXkDDeLjFXneqm0U9C6R-6OmnpYeVbHZ9RinYRDs47K0Qj8CpRvIz0j-ed7wS_eBI8xwIRCkom0FDVeKAnX1hRUzgIjNMdEEkr_7ShdPWKuQC1wDLtc4ITvrIva6Y0C3IJlxNAU5P7TTaE9JpwiSKhQwylKbWrZ0NFbr0l4siiFfZ2u0M06TkpW2tC7Hc4gnWbrIgvbac45E_wm66z0ovvg9n5-2y8k-XLhoba0tMEdNEGrHfPNDopW2lV7QwmWtVlG_gc-yiRXRdtwFnUykK1ES2pZHVWlL4mG49gNDNC5fqTjOwVxVmFDcEHscFcL2oJpXtwSGmFpeFwsoxFasaFbytdqTRaaUiWbKA6VVQyyJKVJyrlTkqhxRobUjrnSByZHVTHIon-kjjGagiSiF6pX5etlJAmNUr-5MPKSJT_nT0zEujQVpnLQaWdw4DVtjkZFa83J3MYwDeneE1R9DMZ76RcCdcnZ0X0N0j5iNg3IyKtrBkFaWzNKDyR0Bcxx7UJPGaByOPJGOQYmYWdaqlOPizwWTRam4KOmWvDVUhviK7y_3O8wiBCYQHIaqxmM4NoDgIOJDLjqE3LE3E4B83akjpWkJLwwCc1o6XX2ZaUpt1Hssmc-xNdYU0I4oKbLPKsSynLcW8wovLYktFmBI82042JvWHq2GfxDoVBSu2hHO7X1R4TERBV-dtc7gVGjbiE6GG7P0XnrJdmiGcQ44PhOPhV_m-BuNinHKqGqgZy0QgyJZSs8xQGBO12OMyF8TbsZRY8yzn-BAMWlWg8cYwdlO5C-TKn1LLAB2TC8oQO8f0sv2lxC4RDQuXdjAgS3X0SEMpU2aexrLpB0QYMfovyiyIuJKqQxEbyKGk6HHYcAd0WrpG4046-bSKp90s3O3SN5OnD2bfHO1X4sBFiF_3a6728vHR3SGzYCr8Sirs-2_Z2AAJpPqqc-KPsqDeDfxfrmfqnCPVSSmf6dknU019yxnACjOoB7UktqCGRapIFlSZFoPMViqn4grd3-jZKKOVND77kVgCXP0YX-_nCy2YBjIOMEfRvMtcCfczu7joFcv-KkVy4lRJk-zu8hsxKksqGMxksnaKLZOeh0N21jEvLZ_F6RBOEmnSDRKOq0iHbZYyDhLckmnGu_A2DGRrCqAb4Nkz2qHIToQyaXrBg76TBJQ7lwVI26-XlnVnOrOL0oE7NdH2rBy2lHjVbH85AGjCjONTyPettllsVvPpHHenPL5QtER1k2pb0M8Qab2X5HgsUIIF6twLU1ZM66ylGoKTa_VXQf3LRyO2Xe3DTHuTWi7YZCe29x3mi3lkQ4EDtL6a7JFbSVFI5JWE26Y5hNQWWdBxFyCnu7pjIz30UYi_mtUUvEjCTuoioPcJAwtE0EmehZ07JjqqM5X9hGYuYg1wPK8j3k-zfSrvHcAOb0aC6StVoh62crNOeqZTyNKOmhBpqIF1-YjKDeLO5lKpjYwlv_boCKqSBfPmJTTvy3foW4mUnOTWFLOANRD04N2pH3pyFd6W-wRzR4GGVGoyVyIdg9cM9CSF4OvAVh78cVoIjeyXRFUiNPRh8AsFaQlvJYqTKQ27qaVFTkVpM6Bir8GkThwHmNXWYoS0kzTBNRU0JGctq7wNKSAsZVfum8hk5gLTH2ZqFdS0hwTYxhBIpbwdBP19QJOQphIXaEkaaKk6TMVddtKmrOIm0kU-2bywdEPn_jJmuKY42szDwhHo5YKXSA6xJPFFG1FOrIuKgMHA0mSPFJkXI9FTmqjNWWfzKBFYHz7I6_ThTfOrcVCAxJ5DOc7VXlXYdR1jf1P2B0Q7MSeacpVRUUkgyUX1Grb9PAUspKCSSDixI28USsnK5jyA_ko0Afbx9g-kWCM6W-yhC1NE5uzNIZTegcIGpsGx-2N3QAq8ldtxDGmMbHhgTUQtM2Khpto0ptlGUHpkamrFSRL7HYI4CA3pON1zN9W3R_hECPyvlKoBrCxjW01QbE-eQhtvQgsZ1ePBe0K4JIT0PGolSrdVJQ424bWlkYG2zTVh5W6fjOg7yLWFG7QzOqIUpP6krUwt9Nx_TSVsjMmlh7XNboDFqS6DWDG_YeJBGDX3IoLHh2ozuF45Wdn1WTe9h01ho0MKEmtSdB02Zt-lY3Xqot3r-t1bg1jxL44i4aVDShmtrboJtrFUtLZuDtuaI29g1NnYRY2srG1r7QrctU2g-i1obulFjVtrIlltKfVqLS4cNXc2o6XQeWU_ngTWipczIte541NhdpK-GeskOlH7wwVGAPfWk4weWhxyRvmSj9r3UewwWrsg62cvSH8XdrKzGEURQLC95q8sa5U2sBUU-3jAaYJ69znDdUfZAA8tbP_L8r3Ra_iZs0B-MhiVc6cLt26BxCvA1uzvsC47oE1ljfil3Pk-By73JU8EFPtlb_u6ErAl9WKmbhp5A63zD5S3Yp36po-QVIKP0EYWndTIuIw_fjZmw6vkMpoAnn3CcZLJf0GRA5K2qG0Qpe4HeYJ5u8T2STwTi4CS_R0Nffvl4kuFsKLfZH2iRfyIEcxwo7tVwepiuzIc005fpuOZdl4XX6nvEW3D5wcV-Run-JBflYSs-wrNA8fILordBk8Hn6ecSrrxjaCiuup1XltliXhbeSxqPjXQK7wzL0WyS_byvkumoPAnkEYOFMIXHpTa8ZXPNYKpntrkBB_6-aU4_T47nk5VFyQfU6dO8U5BRpopd9oLaBDc-mrnFt1BVXrGs9-KTsl62-uiLoeorvbYp3-45fzO2_Y--LqjWOE9wuWLK6n-rallKLikOOyfOeaDDs97hXwL7BzOhnU0=

Imbued support are not included as support gems in the compared "Skills" tab.

Before screenshot:
Screenshot 2026-04-18 143837

After screenshot:
Screenshot 2026-04-18 143725


Overlapping text in "Calcs" tab for Auras/Buffs & Curses/Debuffs

Before screenshot:
image

After screenshot:

Screenshot 2026-04-18 150355

Incorrect set of config options being shown

Before screenshot:
Screenshot 2026-04-03 223439

After screenshot:
Screenshot 2026-04-18 152559


Overlapping text in "Config" tab for interactable elements

Before screenshot:
image2

After screenshot:
Screenshot 2026-04-18 154638


Horizontal scrolling is needed in the "Items" tab for the wide "static" content

Before screenshot:
Screenshot 2026-04-18 163425

After screenshot:
Screenshot 2026-04-18 164353


Content driven layout split with scrollbars rather than a 50/50 split

Before screenshots:
image
image

After screenshots:
image
image

@LocalIdentity LocalIdentity self-assigned this Apr 18, 2026
@LocalIdentity LocalIdentity added the technical Hidden from release notes label Apr 18, 2026
@LocalIdentity LocalIdentity merged commit 69dbd29 into PathOfBuildingCommunity:dev Apr 18, 2026
3 checks passed
@LocalIdentity LocalIdentity changed the title fix/compare-tab-issues Fix various compare tab issues Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

technical Hidden from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants