fix: hide data queried dropdown when empty#1604
Open
reverb256 wants to merge 1 commit intoPostHog:mainfrom
Open
fix: hide data queried dropdown when empty#1604reverb256 wants to merge 1 commit intoPostHog:mainfrom
reverb256 wants to merge 1 commit intoPostHog:mainfrom
Conversation
The DataQueriedCollapsible component would show the 'Data queried' button even for whitespace-only content. Now trims before checking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #1574
The "Data queried" collapsible button shows up even when there is no data queried, because whitespace-only or empty strings pass the falsy check.
Solution
Changed
if (!text) return nulltoif (!text.trim()) return nullinDataQueriedCollapsible. This hides the dropdown when the content is empty, whitespace-only, or undefined.Files Changed
apps/code/src/renderer/features/inbox/components/detail/SignalCard.tsx— 1 line changed