fix: distinguish missing baseline from Site API fetch error#122
Merged
Conversation
fetchPreviousRun now returns a discriminated PreviousRunResult so
callers can tell a genuine 404 ("no baseline on branch") apart from
a 5xx/timeout/network failure. main.ts emits the existing "no baseline"
guidance only on not-found, and a distinct transient-error warning
(with the reason) when the fetch itself fails.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Query Doctor Analysis
2 queries analyzed
2 pre-existing issues
SELECT "guests"."id", "guests"."session_id", "guests"."username", "guests"."avatar_path", "guests"."color", "guests"."side", "guests"."audio_recording_path", "guests"."audio_recording_public", "gue...
indexassets(event_id, inserted_at desc)
cost 31,003,449 → 1,493 (100% reduction)SELECT * FROM guest_ip_addresses WHERE ip_address = '127.0.0.1';
indexguest_ip_addresses(ip_address)
cost 154,402 → 8 (100% reduction)
Using assumed statistics (10000000 rows/table). For better results, sync production stats.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchPreviousRunnow returns aPreviousRunResultdiscriminated union (found/not-found/error) so callers can tell a genuine 404 ("no baseline on branch") apart from a 5xx, timeout, or network failure.main.tsemits the existing "No baseline found... add a push trigger" guidance only onnot-found, and a new warning with the actual reason onerror("Failed to fetch baseline... likely a transient Site API issue — re-run the check to retry.").Test plan
npm run typecheck— cleannpx vitest run— 161/161 passing🤖 Generated with Claude Code