Skip to content

test: cover resolveDockerHost (follow-up to #119)#123

Merged
veksen merged 1 commit intomainfrom
veksen/pr119-followup-tests
Apr 21, 2026
Merged

test: cover resolveDockerHost (follow-up to #119)#123
veksen merged 1 commit intomainfrom
veksen/pr119-followup-tests

Conversation

@veksen
Copy link
Copy Markdown
Member

@veksen veksen commented Apr 20, 2026

Summary

  • Export resolveDockerHost so it can be unit-tested directly.
  • Add tests covering non-localhost passthrough, escapeDocker same-host passthrough, reachable/unreachable docker-host probes, and the onFullSyncredump integration that verifies lastSourceDb holds the resolved db. Closes Write tests for resolveDockerHost (follow-up to #119) #121.

Test plan

  • npx vitest run src/remote/resolve-docker-host.test.ts (5/5 pass)
  • npx vitest run (168/168 pass, no regressions)
  • npx tsc --noEmit

🤖 Generated with Claude Code

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Query Doctor Analysis

View full run details

2 queries analyzed

2 pre-existing issues

Using assumed statistics (10000000 rows/table). For better results, sync production stats.

Covers the two observable outcomes of PR #119: when the docker-host
probe succeeds, onFullSync syncs from (and redump reuses) the escaped
host; when it fails, both fall back to the original. Closes #121.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@veksen veksen force-pushed the veksen/pr119-followup-tests branch from 7c586a1 to e7d7d3e Compare April 20, 2026 21:08
@veksen veksen requested a review from Xetera April 21, 2026 17:07
@veksen veksen merged commit 46404db into main Apr 21, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write tests for resolveDockerHost (follow-up to #119)

2 participants