Avoid nonunique contrast names from rascal-1 project#436
Open
StephenNneji wants to merge 2 commits intoRascalSoftware:masterfrom
Open
Avoid nonunique contrast names from rascal-1 project#436StephenNneji wants to merge 2 commits intoRascalSoftware:masterfrom
StephenNneji wants to merge 2 commits intoRascalSoftware:masterfrom
Conversation
DrPaulSharp
approved these changes
Apr 20, 2026
Collaborator
DrPaulSharp
left a comment
DrPaulSharp
left a comment
There was a problem hiding this comment.
All looks good. Whilst reviewing I saw a bug on line 206 of r1ToProjectClass.m - backGround should read background. Do you mind sorting that whilst we're here please?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to RascalSoftware/RasCAL-2#216