Generic filter module for exclusive cross section sample production#904
Generic filter module for exclusive cross section sample production#904
Conversation
afropapp13
left a comment
There was a problem hiding this comment.
Many thanks for all the work, happy with the filter!
|
Hi @tbwester This filter looks incredibly useful, and its usefulness extends beyond SBND. I think this should live in LArSoft, so that other experiments can make use of it (I can already think of some usecases). The filter could live alongside a LArG4 filter I wrote years ago: https://github.com/LArSoft/larevt/blob/52fa202b71b6186ccc54522651107e9ea7a5724e/larevt/Filters/LArG4ParticleFilter_module.cc |
|
Hi @absolution1 thanks! I considered putting it upstream but then I'm not sure how to implement experiment-specific definitions for the fiducial volume option. Do you know of any way? |
|
hi @tbwester Sorry I completely missed your response. I had a look at the code, and it looks like its using my old RecoUtils library, I didn't expect this to still be in use. You could copy/paste the function into your filter module. Is this what you mean? |
Description
Filter module that is configurable for specifying common requirements for cross section signal definitions. This PR is a draft since other options may need to be added.
Features:
Some example signal definition configurations are added to
fcls/signal_filters_sbnd.fcl.Checklist
Reviewers,AssigneesDevelopement