-
Notifications
You must be signed in to change notification settings - Fork 44
fix(hooks): propagate errors in useAsyncCallback to the React error boundary #612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Just-Insane
wants to merge
5
commits into
SableClient:dev
Choose a base branch
from
Just-Insane:fix/async-callback-rejections
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+22
−2
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
85a7f6d
fix(hooks): handle unhandled rejections in useAsyncCallback
Just-Insane 918f2d7
chore: add changeset for async-callback-rejections
Just-Insane 9ebd8d3
Merge branch 'dev' into fix/async-callback-rejections
Just-Insane cbd653e
docs(changeset): accurately describe unhandled-rejection suppression …
Just-Insane 68d653d
Merge branch 'dev' into fix/async-callback-rejections
Just-Insane File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| default: patch | ||
| --- | ||
|
|
||
| Suppress "Uncaught (in promise)" console noise for fire-and-forget `useAsyncCallback` call sites; errors are still surfaced to callers that await the returned promise and captured in `AsyncState` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The added no-op
p.catch(() => {})marks the rejection as handled, which preventsunhandledrejectionfrom firing. In this repo Sentry is initialized with default browser integrations, so this will likely stop fire-and-forget failures from being captured/reported and can make production errors harder to detect. If the goal is to surface failures to the app’s error handling, consider either (a) removing the no-op catch and fixing call sites that truly need to ignore errors, or (b) reporting the error explicitly (e.g., via Sentry/logging) and/or rethrowing on a separate task so it still reaches global error handling.