Fix sign indexing#8585
Open
APickledWalrus wants to merge 2 commits intodev/patchfrom
Open
Conversation
APickledWalrus
requested review from
Absolutionism and
UnderscoreTud
and removed request for
a team
skriptlang-automation
Bot
added
needs reviews
1 task
This comment has been minimized.
This comment has been minimized.
skriptlang-automation
Bot
added
bug
sovdeeth
approved these changes
Apr 23, 2026
Absolutionism
approved these changes
Apr 23, 2026
github-project-automation
Bot
moved this from In Review
to Awaiting Merge
in 2.15 Releases
skriptlang-automation
Bot
added
patch-ready
UnderscoreTud
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As described in #8577, there is a regression in 2.15 causing signs to now be 0-indexed rather than 1-indexed.
Solution
I added a small utility method to handle adjusting the line. I also added runtime errors for out of range inputs.
There is an additional bug fix in TypePatternElement for a log handler error that was being printed.
loopLog.printError()was being called beforeexprLogwas stopped. The solution was to simply remove the call as it will be handled in one of thefinallyblocks further down.Testing Completed
I added a test for getting/setting for valid/invalid inputs.
Supporting Information
Completes:
Related: none
AI assistance: none